Remove duplicate #include statements#21085
Merged
TimWolla merged 2 commits intophp:masterfrom Jan 30, 2026
Merged
Conversation
khaledalam
requested review from
bukka,
dstogov,
kamil-tekiela and
ndossche
as code owners
DanielEScherzer
requested changes
Jan 29, 2026
Member
DanielEScherzer
left a comment
DanielEScherzer
left a comment
There was a problem hiding this comment.
checked all files, mostly looks good but one file has issues
Contributor
Author
|
Thanks @DanielEScherzer for the feedback, yes I were try to be careful about exclude conditional ones but i missed that file. |
TimWolla
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove 26 duplicate
#includestatements from 21 files across the codebase.Motivation
Compile-Time Impact
Removes 26 redundant file lookups and preprocessor guard evaluations during compilation.
Changes
Notable duplicates removed:
php.h,php_globals.hin SAPI fileszend_vm_opcodes.hin zend_compile.hhttp_core.hin apache2handler (3 files)<sys/types.h>in multiple wrappersNotes
#if/#elifbranches